KNOX-2969 - KnoxSSO Cookies should be ignored while calculating token limit per user #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroflag
approved these changes
Oct 18, 2023
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…ating token limit per user (apache#805) Change-Id: I7248ef2da620b2bdd81223d83d3a14acf5ee7deb
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…into cdpd-master * changes: CDPD-62588, KNOX-2972: Session resource can generate application logout URL with profile/topologies query parameters (apache#808) CDPD-62595, KNOX-2970: Removing KnoxSSO cookie from the token state service upon logout (apache#806) CDPD-62598, KNOX-2971: Applying word wrapping in the comment and metadata columns on the Token Management UI (apache#807) CDPD-62592, KNOX-2969: KnoxSSO Cookies should be ignored while calculating token limit per user (apache#805) CDPD-62585, KNOX-2968: Batch token enable action should succeed even if enabled KnoxSSO cookies are selected (apache#804) CDPD-61809, KNOX-2961: Knox SSO cookie Invalidation - Phase II (apache#799) CDPD-61184, KNOX-2961: Knox SSO cookie Invalidation - Phase I (apache#797)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modified the logic used for calculating the token limit per user in a way such that it ignores the previously generated KnoxSSO cookies. That is, a user can have as many KnoxSSO cookies as they want, but regular tokens are still limited.
How was this patch tested?
Updated JUnit tests and executed manual testing:
adminuser